Simplify createDerivedStore in debug.derived.ts #1801
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t expose `set` and `update`.
dskloetd
force-pushed
the
kloet/readable-store
branch
from
bdd4b9b to
0afb9d5
Compare
lmuntaner
reviewed
Feb 2, 2023
|
Actually, I forgot to bind the method to the object so I expect it won't work. |
|
Should this PR be closed ? |
|
@dskloetd what do you think? |
|
Does it matter? It's marked as Draft already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Small optimization.
If all we want is a Readable view on a writable store, that doesn't expose
setandupdate, creating a derived store is overkill.The derived store subscribes to the original and forwards the changes but this is not necessary.
Changes
Change createDerivedStore to simply return an object with the same subscribe method and no other methods.
Tests
Refactoring should be covered by existing tests.